Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote oca #1427

Merged
merged 2 commits into from
Sep 6, 2023
Merged

feat: remote oca #1427

merged 2 commits into from
Sep 6, 2023

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Sep 5, 2023

  • Added support for remote oca
  • Removed hardcoded oca bundles and assets.

After merging this PR you will have to add OCA_URL environment variable to your .env file.
Right now you should use OCA_URL=https://raw.githubusercontent.com/wadeking98/aries-oca-bundles/fix-script-trailing-comma/ because there's a bug in the main branch of the ares-oca-bundles repo that I'm fixing. Soon you'll be able to use the official repo which is: https://raw.githubusercontent.com/bcgov/aries-oca-bundles/main/

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wadeking98 wadeking98 requested review from cvarjao and jleach September 5, 2023 23:53
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure why those Bifold changes are being included in the diff when they are already in main in this repo

@wadeking98 wadeking98 merged commit 960d262 into bcgov:main Sep 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants